Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive templates #5628

Merged
merged 6 commits into from
May 5, 2023
Merged

Inactive templates #5628

merged 6 commits into from
May 5, 2023

Conversation

solth
Copy link
Member

@solth solth commented Apr 17, 2023

Fixes #3311

@solth solth requested a review from BartChris April 17, 2023 17:22
@BartChris
Copy link
Collaborator

BartChris commented May 5, 2023

Activating and deactivating the display of inactive templates works good! But after this change it is possible to not only show a deactivated template, but also to create processes from it. Should that be possible?
An indication in the UI, if a template is active or inactive (we have something like that for projects) would also be good.

@solth
Copy link
Member Author

solth commented May 5, 2023

Activating and deactivating the display of inactive templates works good! But after this change it is possible to not only show a deactivated template, but also to create processes from it. Should that be possible?
An indication in the UI, if a template is active or inactive (we have something like that for projects) would also be good.

Thanks alot for the review. You are absolutely correct that deactivated templates should not be available for process creation (they are already skipped when creating a process for a specific project via the project list). I will make a corresponding change and then re-request a review from you.

@BartChris
Copy link
Collaborator

Looks good to me now!

@solth solth merged commit 67f9368 into kitodo:master May 5, 2023
@solth solth deleted the inactive-templates branch May 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove switch to create unreachable production templates
2 participants