Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list function for renaming media of multiple processes #5824

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add list function for renaming media of multiple processes #5824

merged 1 commit into from
Nov 16, 2023

Conversation

solth
Copy link
Member

@solth solth commented Nov 1, 2023

Fixes #5806

markusweigelt
markusweigelt reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, some Codacy problems need to fix here and I have a few more questions about PR.

Kitodo/src/test/java/org/kitodo/production/services/file/FileServiceIT.java Outdated Show resolved Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/file/FileServiceIT.java Outdated Show resolved Hide resolved
Kitodo/src/main/java/org/kitodo/production/forms/ProcessForm.java Show resolved Hide resolved
@solth solth marked this pull request as draft November 14, 2023 13:50
markusweigelt
markusweigelt approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this implementation. It works on my machine!

  • The wording of the error might need a slight adjustment. Error (org.kitodo.exceptions.TooManyProcessesSelectedException): Die maximal erlaubte Anzahl an Vorgängen (1) für die Medienumbenennung wurde überschritten (2).
  • The function of media renaming in the editor and the functions of this pull request should be included in the documentation at an appropriate location. I believe that by setting the authority, one might not be aware that there is an additional configuration option.

@solth
Copy link
Member Author

solth commented Nov 16, 2023 •
edited
Loading 

* The wording of the error might need a slight adjustment. `Error (org.kitodo.exceptions.TooManyProcessesSelectedException): Die maximal erlaubte Anzahl an Vorgängen (1) für die Medienumbenennung wurde überschritten (2).`

I have adjusted the message to avoid confusion.

@solth solth marked this pull request as ready for review November 16, 2023 12:52
@solth
Copy link
Member Author

solth commented Nov 16, 2023 •
edited
Loading 

* The function of media renaming in the editor and the functions of this pull request should be included in the documentation at an appropriate location. I believe that by setting the authority, one might not be aware that there is an additional configuration option.

Documentation added here and here

@solth solth merged commit e2403b6 into kitodo:master Nov 16, 2023
2 checks passed
@solth solth deleted the rename-media-list-function branch November 16, 2023 17:46
@solth solth mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusweigelt markusweigelt markusweigelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename media of multiple processes
2 participants
@solth @markusweigelt