Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of bug fixes #96

Merged
merged 3 commits into from
Nov 2, 2017
Merged

Couple of bug fixes #96

merged 3 commits into from
Nov 2, 2017

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Nov 2, 2017

No description provided.

when updating a case-run status comments are optional. However the
form HTML was displaying required="" and the validation error
reported in Issue #77 is generated on the browser side.

This commit explicitly sets the required attribute to False!
The Export To XML and Export To CSV buttons have been removed.
The export functionality is only useful for integration with other
systems and we have an API layer for that. Any future work in the
export area should be done on the API side.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 58.373% when pulling 0331bb0 on next_release into 619c283 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 58.373% when pulling 0331bb0 on next_release into 619c283 on master.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Pull Request Test Coverage Report for Build 321

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 58.373%

Files with Coverage Reduction New Missed Lines %
tcms/testruns/helpers/serializer.py 3 0.0%
tcms/report/views.py 6 21.21%
Totals Coverage Status
Change from base Build 319: -0.2%
Covered Lines: 7057
Relevant Lines: 11265

💛 - Coveralls

@atodorov atodorov merged commit d1c170b into master Nov 2, 2017
@atodorov atodorov deleted the next_release branch November 2, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants