Repository navigation
Invalid zip file in release package #1264
|
We are experiencing a problem downloading any klauspost:compress release zip package since v1.16.0. Our process requires a 'scan for threats` prior to download but the scan fails on a zip file it cannot access. Browsing the latest v1.20.3.zip, I do find an invalid zip file at zip/testdata/test-prefix.zip.
|
Replies: 1 comment 2 replies
|
Both are intentional. |
Both are intentional.
zip/is a fork of the standard library'sarchive/zip, and itstestdataholds the fixtures from Go's own zip tests.test-prefix.zipis a valid archive with the text "prefix that could be an executable jar file" in front of it, used to test zips that don't start withPK(thetest-prefix.zipcase in zip/reader_test.go), and Python's zipfile opens it fine. There's no package without test data: GitHub builds the "Source code" zip of a release from the whole tagged tree, and the module zip thatgo mod downloadgets from proxy.golang.org has the samezip/testdatafiles. A few other fixtures there are odd on purpose too, liketest-trailing-junk.zipandtest-badbase.zip, so a…