This repository was archived by the owner on Jun 30, 2022. It is now read-only.
Get all contracts #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1c01a5
approved these changes
Nov 10, 2017
satello
force-pushed
the
getAllContracts
branch
from
0d19523 to
4798215
Compare
n1c01a5
reviewed
Nov 13, 2017
contract_wrapper/ContractWrapper.js
Outdated
| @@ -78,6 +77,7 @@ class ContractWrapper { | |||
| ) | |||
| return contractDeployed | |||
| } catch (e) { | |||
| console.log(e) | |||
There was a problem hiding this comment.
I think it is better to avoid console.log() in the code, only for debug or for the commands.
n1c01a5
reviewed
Nov 13, 2017
contract_wrapper/KlerosWrapper.js
Outdated
|
|
||
| // FIXME allow for other contract types | ||
| const ArbitrableTransaction = new ArbitrableTransactionWrapper(this._Web3Wrapper, this._StoreProvider) | ||
|
|
||
| newDisputes = [] | ||
| const newDisputes = [] | ||
| for (let i=0; i<myDisputes.length; i++) { |
n1c01a5
reviewed
Nov 13, 2017
script/deployKlerosPOC.js
Outdated
| @@ -15,11 +15,11 @@ let deployKlerosPOC = async () => { | |||
|
|
|||
| const PNK = await KlerosInstance.pinakion.deploy() | |||
There was a problem hiding this comment.
the name of this variable can be more explicit like pnkContractDeployed
n1c01a5
approved these changes
Nov 13, 2017
satello
force-pushed
the
getAllContracts
branch
from
4000417 to
ded6a97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.