chore: label text improvements #2088
Conversation
❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
|
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughUpdated user-facing label strings in DisputeView CardLabels; keys, logic, rendering, and APIs unchanged. Only several label text values were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/src/components/DisputeView/CardLabels/index.tsx (1)
68-68: Tone nit: prefer neutral phrasing over “forgot.”“You forgot to vote” may read as accusatory. Consider a neutral alternative like “You didn’t vote” or “No vote cast” to avoid blame-y tone.
Proposed change:
- DidNotVote: { text: "You forgot to vote", icon: ForgotToVoteIcon, color: "purple" }, + DidNotVote: { text: "You didn't vote", icon: ForgotToVoteIcon, color: "purple" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
web/src/components/DisputeView/CardLabels/index.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: Redirect rules - kleros-v2-neo
- GitHub Check: Header rules - kleros-v2-neo
- GitHub Check: Pages changed - kleros-v2-neo
- GitHub Check: Redirect rules - kleros-v2-testnet
- GitHub Check: Redirect rules - kleros-v2-testnet
- GitHub Check: Header rules - kleros-v2-testnet
- GitHub Check: Header rules - kleros-v2-testnet
- GitHub Check: Redirect rules - kleros-v2-university
- GitHub Check: Header rules - kleros-v2-university
- GitHub Check: Pages changed - kleros-v2-testnet
- GitHub Check: Pages changed - kleros-v2-testnet
- GitHub Check: Pages changed - kleros-v2-university
- GitHub Check: SonarCloud
- GitHub Check: contracts-testing
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
web/src/components/DisputeView/CardLabels/index.tsx (2)
64-67: Voice consistency and clarity improvements look good.Switching to second-person phrasing (“You …”) improves clarity and keeps messaging consistent across statuses. The updated casing (“Evidence time”) also aligns with sentence case. No logic changes introduced. LGTM.
Also applies to: 70-70
66-66: Confirm copy accuracy during commit phase (“commit” vs “vote”).This label is shown for both “commit” and “vote” periods (see Line 125). “You can vote” might be slightly imprecise during “commit.” If product intent is to keep generic copy, all good; otherwise, consider differentiating commit vs vote phrasing.
Would you like me to propose a minimal conditional copy tweak that preserves existing logic and only adjusts the string based on period?
|
jaybuidl
added
Type: Enhancement ✨
Package: Web
PR-Codex overview
This PR focuses on updating the text descriptions in the
LabelArgsobject within theCardLabelscomponent to provide clearer and more user-friendly messages.Detailed summary
textvalues forEvidenceTime,NotDrawn,CanVote,Voted, andDidNotVoteto be more user-friendly.textforFundedto "You funded an appeal" for clarity.Summary by CodeRabbit