Refactor(web)/delete web3 react files #949
Conversation
|
yep, the connector is not needed, and regarding the |
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for kleros-v2-contracts ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
web/src/components/ConnectButton.tsx
Outdated
| <Button disabled={isOpen} small text={"Connect"} onClick={async () => await open({ route: "ConnectWallet" })} /> | ||
| ); | ||
| const { open, isOpen } = useWeb3Modal(); | ||
| if (isConnected && chain && chain.id !== DEFAULT_CHAIN) { |
There was a problem hiding this comment.
Break this statement in two:
if (isConnected)
if (chain && chain.id !== DEFAULT_CHAIN)
switchButton
else
display
else
connect
web/src/components/ConnectButton.tsx
Outdated
| return <AccountDisplay />; | ||
| } else { | ||
| return ( | ||
| <Button disabled={isOpen} small text={"Connect"} onClick={async () => await open({ route: "ConnectWallet" })} /> |
There was a problem hiding this comment.
abstract this into a component
| /> | ||
| ); | ||
| }; | ||
|
|
||
| const ConnectButton: React.FC = () => { |
There was a problem hiding this comment.
rename component and file to ConnectWallet
| } | ||
| }} | ||
| /> | ||
| {chain && chain.id === DEFAULT_CHAIN ? ( |
There was a problem hiding this comment.
abstract this into ensureChain function, that receives a ReactNode and wraps it with the check
|
Kudos, SonarCloud Quality Gate passed!
|
maybe this is not done correctly:
and I don't know if we need the files
utils/switchChain.tsandWrongChainBoundary.tsxetc anymore