-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] Prober targets service instead of pods directly #2159
[release-1.3] Prober targets service instead of pods directly #2159
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2159 +/- ##
==============================================
Coverage ? 67.67%
Complexity ? 671
==============================================
Files ? 141
Lines ? 6852
Branches ? 196
==============================================
Hits ? 4637
Misses ? 1829
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@pierDipi what about the |
Manual cherry pick into 1.2 branch: #2180 |
This is an automated cherry-pick of #2112