Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests running simple workflow in e2e #112

Merged
merged 4 commits into from
May 17, 2019

Conversation

navidshaikh
Copy link
Collaborator

Fixes #104

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2019
@knative-prow-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 15, 2019
@cppforlife
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2019
 also removes http:// before the registry name
@navidshaikh
Copy link
Collaborator Author

/test pull-knative-client-integration-tests

@navidshaikh
Copy link
Collaborator Author

navidshaikh commented May 16, 2019

e2e tests are failing with

 Service 'hello' successfully created in namespace 'default'.
NAME    DOMAIN                      GENERATION   AGE   CONDITIONS   READY     REASON
hello   hello.default.example.com   1            2s    0 OK / 3     Unknown   RevisionMissing : Configuration "hello" is waiting for a Revision to become ready.
Internal error occurred: admission webhook "webhook.serving.knative.dev" denied the request: mutation failed: Failed to parse image reference: spec.runLatest.configuration.revisionTemplate.spec.container.image
image: "", error: could not parse reference

that's ./kn service update hello --env TARGET=kn || fail_test issued after kn service get.

@navidshaikh
Copy link
Collaborator Author

The tests pass after removing service update command from e2e. 🤔

@navidshaikh
Copy link
Collaborator Author

Well, service update command is trying to set image to "". Bug!

 also increases the sleep time between create and get
@navidshaikh
Copy link
Collaborator Author

The fix for failing integration tests is #118.

@sixolet
Copy link
Contributor

sixolet commented May 17, 2019

/retest

@sixolet
Copy link
Contributor

sixolet commented May 17, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@knative-prow-robot knative-prow-robot merged commit 1b92b1f into knative:master May 17, 2019
rhuss pushed a commit to rhuss/knative-client that referenced this pull request May 27, 2019
* Tests running simple workflow in e2e

 Fixes knative#104

* Adds e2e test for --force flag while creating service

 also removes http:// before the registry name

* Removes the update command

* Adds the service update command back to e2e tests

 also increases the sleep time between create and get
maximilien pushed a commit to maximilien/client that referenced this pull request May 28, 2019
* Tests running simple workflow in e2e

 Fixes knative#104

* Adds e2e test for --force flag while creating service

 also removes http:// before the registry name

* Removes the update command

* Adds the service update command back to e2e tests

 also increases the sleep time between create and get
@navidshaikh navidshaikh deleted the fix-104 branch November 18, 2019 12:38
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests to match the Basic workflow
4 participants