-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests running simple workflow in e2e #112
Conversation
Hi @navidshaikh. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
also removes http:// before the registry name
/test pull-knative-client-integration-tests |
e2e tests are failing with
that's |
The tests pass after removing |
Well, |
also increases the sleep time between create and get
The fix for failing integration tests is #118. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Tests running simple workflow in e2e Fixes knative#104 * Adds e2e test for --force flag while creating service also removes http:// before the registry name * Removes the update command * Adds the service update command back to e2e tests also increases the sleep time between create and get
* Tests running simple workflow in e2e Fixes knative#104 * Adds e2e test for --force flag while creating service also removes http:// before the registry name * Removes the update command * Adds the service update command back to e2e tests also increases the sleep time between create and get
Fixes #104