Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to REST API readme #225

Closed
wants to merge 23 commits into from
Closed

Updates to REST API readme #225

wants to merge 23 commits into from

Conversation

averikitsch
Copy link
Contributor

@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2018
@rgregg rgregg mentioned this pull request Jul 20, 2018
Closed
11 tasks
averikitsch and others added 5 commits July 20, 2018 13:32
@averikitsch
remove traffic splitting
785fb63
@averikitsch
Fix perl command
24e5690
@rgregg @google-prow-robot
Add slack guidelines (#224)
c4d0979 
* Create slack-guidelines.md

* Update slack-guidelines.md

* Update slack-guidelines.md
@mchmarny @google-prow-robot
Removed timezones (#230)
7cba33d 
Until we have broader coverage
@krancour @google-prow-robot
improve blue/green demo doc (#226)
13a3f1b
labadav
labadav reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@labadav labadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approval

Thank you, Averi.

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
samodell and others added 13 commits July 20, 2018 15:28
@samodell @google-prow-robot
Edits to build-private-go sample (#213)
996815a 
* Edits to build-private-go sample

* More edits

* Fixing broken link

* Final edits

* Small tweaks to formatting; code comments

* Making Ryan's edits
@labadav
Adding license
0c21d7a
@labadav
Reorder links
6ea6b9a
@grantr @google-prow-robot
Link to eventing docs in eventing repo (#228)
4024489 
Previous links were broken.
@labadav
Delete knative-audience.png
b617390
@labadav
Updating final version of the audience graphic
785a93f
@labadav
Update README.md
2f5317d
@averikitsch @google-prow-robot
add Traffic Splitting sample (#227)
9379197 
* Add traffic splitting tutorial

* Add traffic splitting tutorial

* remind the user of env vars
@adrcunha @google-prow-robot
Use helpers from prow-tests image for tests (#232)
72cb875 
* Use helpers from prow-tests image for tests

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`presubmit-tests.sh` helper is implemented by knative/test-infra#12
`e2e-tests.sh` helper is implemented by knative/test-infra#17

* Explicitly fail test if setup fails
@adrcunha @google-prow-robot
Use presubmit-tests.sh helper from prow-tests image (#205)
2b03424 
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12
@labadav @google-prow-robot
Fixing language in the source to url sample (#189)
68502bb 
* Fixing language in the source to url sample

* Update README.md

* Update README.md

* Update README.md
@samodell @google-prow-robot
Buildpack sample edits (#222)
b3feaf4 
* First edits to dotnet buildpack

* Updates to buildpack nodejs sample

* More edits to dotnet sample

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Making Ryan's suggested changes - dotnet

* Making Ryan's suggested changes - nodejs
@RichieEscarez @google-prow-robot
Edits + Syncing samples in README.md and build.md (#229)
35ce148
@rgregg
Copy link
Contributor

rgregg commented Jul 23, 2018

/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: averikitsch, rgregg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@averikitsch
Copy link
Contributor Author

/retest

@google-prow-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-prow-robot google-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@averikitsch averikitsch deleted the rest-api branch July 23, 2018 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labadav labadav labadav left review comments

@mattmoor mattmoor Awaiting requested review from mattmoor

@rgregg rgregg Awaiting requested review from rgregg

Assignees

@labadav labadav

Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet