Skip to content

Caesar cipher [Fixed #40] [Fixed #44] #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Caesar cipher [Fixed #40] [Fixed #44] #57

wants to merge 12 commits into from

Conversation

Omkaragrawal
Copy link

I have created my own Caesar Cipher file, along with tests. I Fixed #40 also Fixed #44 .

@ashokdey ashokdey requested review from TheSTL and ashokdey October 9, 2019 07:22
@fcosueza fcosueza mentioned this pull request Oct 9, 2019
Closed
@Omkaragrawal
Copy link
Author

Hey is there any problem with this?

@TheSTL
Copy link
Member

TheSTL commented Oct 10, 2019

Sorry for late reply @Omkaragrawal .
You should debug the code. Don't create your own new algo file.

rahulrana95
rahulrana95 reviewed Oct 11, 2019
View reviewed changes
@Omkaragrawal
Copy link
Author

Hey I have repaired all the expect().toBe() according to @fcosueza 's comments. Now is it OK?

@ashokdey
Copy link
Member

Please look into this @TheSTL

ashokdey
ashokdey requested changes Oct 31, 2019
View reviewed changes
src/_Classics_/caesar_cipher/caeserCipher.js
@@ -0,0 +1,46 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a completely new file is not acceptable. I am marking this PR as Invalid and closing it. However, we can go ahead and keep your Unit Tests somehow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey give me sometime as I have university exams going on, I'll try to update the old code itself asap.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I am not clear as to why a new code (that solves previous issues and have some new features) is not acceptable. Would you not consider this?

@ashokdey ashokdey added changes-requested invalid This doesn't seem right labels Oct 31, 2019
@ashokdey ashokdey closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokdey ashokdey ashokdey requested changes

@TheSTL TheSTL Awaiting requested review from TheSTL

+2 more reviewers

@fcosueza fcosueza fcosueza left review comments

@rahulrana95 rahulrana95 rahulrana95 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Omkaragrawal Omkaragrawal

Labels
changes-requested invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caesar cipher Add Unit Test for - Caeser Cipher
5 participants
@Omkaragrawal @TheSTL @ashokdey @fcosueza @rahulrana95