This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Hide location printing for defmt frames behind another verbosity level #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on knurling-rs/defmt#762.
Addresses #412 and #407.
This PR changes the default (without flags) output to omit location for all defmt frames. Personally I think this is more convenient when you're running your firmware and not debugging it since the log is easier to read and you don't care about locations at this point anyway, but this comes down to personal preference. A less invasive option is to add a
--terse
option and to set the verbosity level to1 + opts.verbose - opts.terse
; then the default output will remain the same.A very minimal solution that addresses #412 but not #407 is to skip printing of location only for
println!
frames ifalways_include_location
is not set, and leave everything else the same.I'm happy to implement any of the options above, or really any other option that's suggested.