Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Hide location printing for defmt frames behind another verbosity level #413

Closed
wants to merge 1 commit into from

Conversation

whitequark
Copy link

@whitequark whitequark commented Jun 20, 2023

Depends on knurling-rs/defmt#762.

Addresses #412 and #407.

This PR changes the default (without flags) output to omit location for all defmt frames. Personally I think this is more convenient when you're running your firmware and not debugging it since the log is easier to read and you don't care about locations at this point anyway, but this comes down to personal preference. A less invasive option is to add a --terse option and to set the verbosity level to 1 + opts.verbose - opts.terse; then the default output will remain the same.

A very minimal solution that addresses #412 but not #407 is to skip printing of location only for println! frames if always_include_location is not set, and leave everything else the same.

I'm happy to implement any of the options above, or really any other option that's suggested.

@Urhengulas
Copy link
Member

Thank you. I will look into the topic

@Urhengulas
Copy link
Member

Superseded by #416

@Urhengulas Urhengulas closed this Aug 1, 2023
@whitequark whitequark deleted the fix-407-412 branch August 1, 2023 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants