-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks video streaming #20
Comments
This project has not been updated for 4 years, and it may not be updated again in the future. I suggest creating another branch for continued maintenance. |
fixed in |
after merging this it seems some of the unit tests are failing, related to the presence of |
I'm planning to read through the rfc for this, to get a deeper understanding of all the nuances https://www.rfc-editor.org/rfc/rfc7233.html Hopefully this will be a bit enlightening and give me some confidence to make more systemic changes. |
This middleware causes videos to fail to stream in Chrome and Firefox.
Here's a minimal repo for reproducing the bug:
https://github.com/jmeyers91/koa-range-broken-video-streaming
Run
node broken.js
andnode notBroken.js
then open http://localhost:8080 and http://localhost:8081The text was updated successfully, but these errors were encountered: