Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks video streaming #20

Closed
jmeyers91 opened this issue Jun 22, 2021 · 5 comments
Closed

Breaks video streaming #20

jmeyers91 opened this issue Jun 22, 2021 · 5 comments

Comments

@jmeyers91
Copy link

This middleware causes videos to fail to stream in Chrome and Firefox.

Here's a minimal repo for reproducing the bug:
https://github.com/jmeyers91/koa-range-broken-video-streaming

Run node broken.js and node notBroken.js then open http://localhost:8080 and http://localhost:8081

@masx200
Copy link
Contributor

masx200 commented Jun 23, 2021

This project has not been updated for 4 years, and it may not be updated again in the future. I suggest creating another branch for continued maintenance.

https://github.com/masx200/koa-range

@masx200
Copy link
Contributor

masx200 commented Jun 23, 2021

fixed in

#24

@masx200
Copy link
Contributor

masx200 commented Jun 23, 2021

mreinstein added a commit that referenced this issue Sep 21, 2022
@mreinstein
Copy link
Contributor

after merging this it seems some of the unit tests are failing, related to the presence of Content-Encoding: chunked header not being present, so I'm hesitant to publish this as an npm module yet.

@mreinstein
Copy link
Contributor

mreinstein commented Sep 22, 2022

I'm planning to read through the rfc for this, to get a deeper understanding of all the nuances

https://www.rfc-editor.org/rfc/rfc7233.html

Hopefully this will be a bit enlightening and give me some confidence to make more systemic changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants