-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lvdocview: remove (unused) crskin
and wolutil
related code
#542
lvdocview: remove (unused) crskin
and wolutil
related code
#542
Conversation
I know there is a lot of stuff we don't use in crengine - but let's keep it so 1) we're not the ones breaking the link with other forks and their ability to pick our stuff and 2) it has happened that looking at that unused stuff gives some explanations of why some stuff/arguments/logic in remote stuff we do use is as it is - so it's best if all the context is kept. |
With the amount of custom changes, I think it makes more sense to not be shy about simplifying stuff. Reduce the barrier to entry, reduce the complexity, reduce compilation time, reduce the final library size, reduce the amount of code you have to wade through… If you want to keep stuff for archeological spelunking, make a branch before cleaning up (I would in fact go as far as removing those unused files too, again less to stuff to wade through). |
You're not losing all that with |
Grep does not care about |
Which is perfectly welcome for my archeological use case.
Thanks! |
I believe that was the very point! 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind removing the other stuff, just keep the long LVDocView::exportWolFile() implementation wrapped in #if 0
.
(I remember I once did find in there some explanation for some stuff present elsewhere, may be some TOC or drawBuf stuff - so it will be good to still be able to find some methods possibly only used in there - and now unused. That you could #if 0
if you really want to then :)
b9a2b98
to
e5f63ed
Compare
- koreader/crengine#527 - koreader/crengine#528 - koreader/crengine#530 - koreader/crengine#531 - koreader/crengine#532 - koreader/crengine#533 - koreader/crengine#534 - koreader/crengine#535 - koreader/crengine#536 - koreader/crengine#538 - koreader/crengine#539 - koreader/crengine#540 - koreader/crengine#541 - koreader/crengine#542 - koreader/crengine#544
- koreader/crengine#527 - koreader/crengine#528 - koreader/crengine#530 - koreader/crengine#531 - koreader/crengine#532 - koreader/crengine#533 - koreader/crengine#534 - koreader/crengine#535 - koreader/crengine#536 - koreader/crengine#538 - koreader/crengine#539 - koreader/crengine#540 - koreader/crengine#541 - koreader/crengine#542 - koreader/crengine#544
Will allow koreader/koreader-base#1675.
This change is