Improvements for UITextInput #2154
Conversation
Kietyo
commented
Feb 19, 2024
•
Kietyo
commented
- Fixes FR: Add a blinking cursor for uiTextInput when user clicks on it #2150
- Added setting to control caret blink duration or to make it static. Also useful for tests.
|
So we have two issues here:
Could you create two separate PRs? |
| // If true, render static non-blinking caret rather than blinking caret. | ||
| val useStaticCaret: Boolean = false |
There was a problem hiding this comment.
I would rename it to blinking caret = true to name it in a positive way.
Or alternatively, change it to configure the duration of the blinking:
val blinkingTime: Duration? = 1.seconds
I would go for the duration, that way we can use 0 or null for static non-blinking.
But as stated in the other comment, I believe this is a separate issue not related to the title of the PR "Support caret on empty text input"
There was a problem hiding this comment.
I'm willing to change the api but not willing to split into separate PRs as it's a PITA. I can just update the title to "Improve UITextInput" to make it more general.
The only reason i added the static caret was for testing anyways.
There was a problem hiding this comment.
Works for me; maybe in the title or subtitle specify something like: allow to configure blinking time and fix care on empty textboxes
Kietyo
changed the title
|
Done. |
| val textInput = stage.uiTextInput() | ||
| val textInput = stage.uiTextInput() {} |
| val useStaticCaret: Boolean = false | ||
| // Controls caret blinking duration. | ||
| // If null, then caret will be static. | ||
| val caretBlinkingDuration: TimeSpan? = 0.5.seconds, |
There was a problem hiding this comment.
companion object {
val STATIC_CARET = TextInputSettings(caretBlinkingDuration = null)
}
| val textInput = uiTextInput() | ||
| val textInput = uiTextInput() {} |
| @@ -195,7 +208,7 @@ class TextEditController( | |||
|
|
|||
| private val gameWindow get() = textView.stage!!.views.gameWindow | |||
|
|
|||
| fun getCaretAtIndex(index: Int): Bezier { | |||
| private fun getCaretAtIndex(index: Int): Bezier { | |||
There was a problem hiding this comment.
Why is this changed to private? Maybe we could rename keeping the old for compatibility to getCaretBezierAtIndex?
| fun getGlyphMetricsForSpaceCharacter(): TextMetricsResult { | ||
| return font.getOrNull()?.getTextBoundsWithGlyphs(fontSize, " ", renderer, alignment) ?: error("Must ensure font is resolved before calling getGlyphMetrics") | ||
| } |
There was a problem hiding this comment.
Since we are adding it, what about?
getGlyphMetricsForText(text: String)So it is more generic. Or at least make it internal.
