FreeBSD support improvements #193
Conversation
Makefile
Outdated
| @@ -38,6 +39,7 @@ ifeq ($(UNAME_S),Darwin) | |||
| endif | |||
| endif | |||
| ifeq ($(UNAME_S),FreeBSD) | |||
| MAKE ?= gmake | |||
There was a problem hiding this comment.
Should this be MAKE = gmake? Otherwise MAKE will already always be set by the first line.
There was a problem hiding this comment.
Whoops, screwed up when pulling these changes into git...
There was a problem hiding this comment.
Does BSD make (e.g., bmake) understand ifeq syntax? If not whatever invokes make needs to be changed. MAKE variable in makefiles is implicitly defined by make implementation.
|
Could you rebase in master as well please? |
|
I just realized it's worth mentioning that the build environment for |
|
I was looking at this and gave up for the time being. I don't know if we can continue packaging kr with these additional dependencies. It's really difficult to manage this with our packaging tools. This now adds hundreds of new dependencies just to build kr (all the cargo crates all the way down) and we don't even have a FreeBSD port/package for emscripten, so I'd have to package that as well. The complexity just to package this tiny piece of software is staggering... edit: our package building environment requires that there is no internet access during build time. This is important for security and reproducibility. |
|
Yes unfortunately the emscripten dependency makes the build much more complex. Once native rust wasm support lands the build dependencies will be reduced significantly. Thanks again for looking into this, we are actively working on lightening the build overall. |
|
Unless someone needs the new Teams feature on a FreeBSD box the current release is probably OK. I'll still rebase this for you, though. |
|
In the meantime we may create a make target that excludes the web dashboard (which would eliminate emscripten and cargo-web build dependencies). Then runtime dependencies would just be libsodium and openssl. |
No description provided.