This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
pkcs11: Cast directly to target types for improved 32-bit support #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2019 16:55
The source type of the session allocator, usize, is variable, as is the destination type of c_ulong. The current usize -> u64 ->(implicit) c_ulong can fail on some systems (e.g., Raspberry Pi uses a 32-bit c_ulong). PKCS kryptco#11 requires only that the size type be at least 32 bits. Casting directly to the destination type allows for greater platform support without affecting existing platforms. I agree to license all rights to my contributions in each modified file exclusively to KryptCo, Inc. Resolves kryptco#89
The implicit conversion from u64 to c_ulong fails on 32-bit platforms. The actual array size is 2 and unlikely to every pose a problem. I agree to license all rights to my contributions in each modified file exclusively to KryptCo, Inc. Resolves kryptco#89
|
I know the README says 32-bit platforms are not supported, but it would be great if you could at least compile your own tools (and the changes are relatively innocuous). |
|
@LoganK we're no longer using the pkcs11 module. It's removed from current master so please give it a try. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kr, krd, and krssh are both working on a Raspberry Pi 4 after these edits.
Resolves #89