VCRUNTIME140_1.dll was not found 1.9.1

[big610]

Attempting to open 1.9.1 Windows Portable, for me fails with: VCRUNTIME140_1.dll was not found.
I held back reporting, due to 1.9.0 W P working & my decision choice for running safely one Windows version behind; 20H2 instead of 21H1.
Today I was expecting Windows 10 21H2 to be released a week after Patch Tuesday, did not happen.
Due to users choosing multiple versions & Windows 11, I chose to inform you, first so you know;
then can determine what happened, choose to fix for compatibility for all, or just notate in release notes.
https://www.bleepingcomputer.com/tutorials/fix-missing-vcruntime140dll-dll-error-in-windows/
VCRUNTIME is on the user for running an older Visual C++ 2015 Redistributable.
But my situation I have 2017, not 2015. Thnx, for a much appreciated excellent program for Windows Portable & Mac.

[DamirPorobic]

You suspect that this will not work with newer version of windows? It might be related to #713 that we drop something that is required to run everywhere, need to look into that.

[antrrax]

To work around this problem in the portable version of windows 10, I manually add these two dll's in the ksnip directory:

msvcp140_1.dll
vcruntime140_1.dll

That's how it works for me

[DamirPorobic]

But that's not good to have to add some dlls manually, we should deliver what we need to run, though this will increase the package size by factor of 2 I think.

[antrrax]

I'm not sure, but I think the microsoft dll's cannot be attached together with the program, you need to send a VCRedist_x64.exe installer with the program. But that doesn't make sense in a portable version, where the Windows user is not allowed to install programs.

https://docs.microsoft.com/en-us/cpp/windows/determining-which-dlls-to-redistribute?view=msvc-160

[DamirPorobic]

Just triggered a build with changed flags for windeployqt, which does the packaging for windows. Can someone test the package in 20min or so.

@antrrax if I recall correctly without this flag you get vc_redist.x64.exe packaged.

[antrrax]

I did the test here on a virtual machine.
Windows 10 Pro
Version 1809 build 17763,107

Without installing vc_redist.x64.exe it will give error with as dll's. But installing the vc_redist.x64.exe included in the package, Ksnip worked correctly.

However, when these microsoft dll's are required, the distribution of the program is no longer portable. Since users without administrator permission will not be able to install vc_redist.x64.exe

[DamirPorobic]

Nah, I don't like it that there must be something installed additionally. Is this also affecting the msi package or just the portable?
Need to google a bit around how other Qt application handle that.

[antrrax]

I did the test with ksnip version .zip (Continuous build)

[antrrax]

Now I tested the msi version of ksnip (Continuous build) on windows 10 and 11 in a virtual machine.

In both cases the .msi installer does not automatically install vc_redist.exe
Although the file is present in the ksnip installation directory.

Then the dll error appears when running ksnip

Windows 11 Pro x64
Versão 21H2 Build 22000.194

Windows 10 Pro x64
Versão 21H1 Build 19043.928

[DamirPorobic]

@antrrax can you check if this was an issue with 1.9.0? If yes, this might be an issue that could be resolved by downgrading the Qt version.

[antrrax]

I tested several previous versions of ksnip and they didn't work.

The problem is that 'Microsoft Visual C++ 2015-2019 Redistributable' (vcredist) is not a native Windows component.
If you install Windows and then install ksnip, this dll error will happen when opening ksnip. Because vcredist is not installed yet.

So you would need to add code in the installer to check if vcredist is already present otherwise, first install vcredist and then install ksnip.

How to: Install Prerequisites in Windows Installer Deployment
https://docs.microsoft.com/en-us/previous-versions/7eh4aaa5(v=vs.90)?redirectedfrom=MSDN

I'm not sure, but apparently msi doesn't have this pre-installation function:
https://developercommunity.visualstudio.com/t/installer-project-with-prerequisites-with-only-msi/602612

See the example of the sketchup 2017:
https://www.mediafire.com/file/cl1f1cth8jkcyys/sketchupmake-2017-2-2555-90783-pt-br-x64.exe/file

If you unzip the file 'sketchupmake-2017-2-2555-90783-en-us-x64.exe' you will see SketchUp2017-x64.msi and the prerequisite files

[dafanasiev]

Maybe use -MT instead -MTd? Its not so good (security, patches, etc.), but not so bad (no vcruntime dlls deps)....

Notes: cmake: MSVC_RUNTIME_LIBRARY or use CL env.

[DamirPorobic]

Maybe use -MT instead -MTd? Its not so good (security, patches, etc.), but not so bad (no vcruntime dlls deps)....

Where are we using those flags?