Repository navigation
darkmux 5.9.1
A security fix for darkmux lab submit. Upgrade if you share runs on darkmux evals.
In darkmux 5.4 through 5.9.0, the evals upload token wasn't tied to the site that issued it, so
lab submit --site <url> sent your evals.darkmux.com token to whatever https host the command
named. That only happened if you ran a command with someone else's --site (a copied command,
say). The token can upload runs and propose evals as you, and can't approve or moderate. If you
ever ran lab submit with a --site you don't trust, make a new token on your account page;
otherwise there's nothing to do, and your existing login keeps working.
Security
lab submit's upload token is kept per site and sent only to the site it was stored for
(#3400). One token was kept per user, solab submit --site <other site>sent the
evals.darkmux.com token to whatever https host was named, andlab submit login --site <preview>replaced it. A token is now keyed by the site's origin (scheme, host and port,
normalized): a--sitewith no token of its own is refused before anything is sent, naming
darkmux lab submit login --site <site>, and another site's token is never used in its place.
login --sitestores only that site's token, andlogouttakes--siteand forgets only
that site's. The evals.darkmux.com token stays where it was (keychain account$USER, or
~/.darkmux/evals-token), so an existing login keeps working; any other site's is kept as
account$USER@<origin>, or in~/.darkmux/evals-tokens/. A site's host is held to DNS's
limits (253 characters, labels of 63), so a long--sitecan no longer split the keychain
command, and a failed keychain store no longer repeats the keychain command's output, which
could carry part of the token.lab submitnever sends a preview's upload token through a proxy. Anhttp_proxysetting
used to route a preview's (plain http) login and uploads through the proxy, Authorization header
and all. A plain-http preview now always goes straight to its site. https keeps your proxy
settings: the proxy sees only an encrypted connection, and some networks have no other way out.