-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added OpenSSL version requirement to README. #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it! |
README.md
Outdated
@@ -6,6 +6,15 @@ | |||
|
|||
Python client for the [kubernetes](http://kubernetes.io/) API. | |||
|
|||
## Requirements | |||
|
|||
A version of python with OpenSSL version 1.0.0 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is the minimum requirement. Worth mentioning this is on mac. What we know is, the client does not work with current OPENSSL_VERSION default on osx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, should I make this a macOS-specific instruction then? If so, I'd mention using brew as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's more appropriate I think. Thanks.
@WilliamDenniss Hey William, are you going to update this PR? I can send another one to fix it if you don't have time. |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 9 9
Lines 668 668
=======================================
Hits 631 631
Misses 37 37 Continue to review full report at Codecov.
|
- SSLError on macOS documented.
No description provided.