Skip to content

README improvements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2016
Merged

README improvements #47

merged 1 commit into from
Nov 28, 2016

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Nov 26, 2016

  • add a pypi badge
  • add a small install section
  • add a community/support section
  • remove code of conduct and point directly to CNCF code of conduct (brandon knows about this)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2016
pip install .
```

From [PyPi](https://pypi.python.org/pypi/kubernetes/1.0.0-alpha.2) directly:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link main pypi kubernetes page instead of an specific version? e.g. https://pypi.python.org/pypi/kubernetes/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed

```
git clone https://github.com/kubernetes-incubator/client-python.git
cd client-python
pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the standard way is to python setup.py install it. from ref:

Get Packages
To use a package from this index either "pip install package" (get pip) or download, unpack and "python setup.py install" it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok addressed this

@@ -1,58 +0,0 @@
## Kubernetes Community Code of Conduct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not better to keep this file and only add a link to CNCF code of conduct? Anyhow we should update template project with any change of this nature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brandon said he will take care of the move , see kubernetes/kubernetes#36817

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. The PR look good except two comments above. Thanks.

@mbohlool mbohlool self-assigned this Nov 27, 2016
@mbohlool mbohlool added this to the v1.0 milestone Nov 27, 2016
@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2016
@mbohlool mbohlool merged commit ff9295b into kubernetes-client:master Nov 28, 2016
yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
Raise exception on duplicated name in kubeconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. documentation_only lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants