-
Notifications
You must be signed in to change notification settings - Fork 3.4k
README improvements #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sebgoa
commented
Nov 26, 2016
- add a pypi badge
- add a small install section
- add a community/support section
- remove code of conduct and point directly to CNCF code of conduct (brandon knows about this)
pip install . | ||
``` | ||
|
||
From [PyPi](https://pypi.python.org/pypi/kubernetes/1.0.0-alpha.2) directly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link main pypi kubernetes page instead of an specific version? e.g. https://pypi.python.org/pypi/kubernetes/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fixed
``` | ||
git clone https://github.com/kubernetes-incubator/client-python.git | ||
cd client-python | ||
pip install . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the standard way is to python setup.py install
it. from ref:
Get Packages
To use a package from this index either "pip install package" (get pip) or download, unpack and "python setup.py install" it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok addressed this
@@ -1,58 +0,0 @@ | |||
## Kubernetes Community Code of Conduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it not better to keep this file and only add a link to CNCF code of conduct? Anyhow we should update template project with any change of this nature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brandon said he will take care of the move , see kubernetes/kubernetes#36817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. The PR look good except two comments above. Thanks.
Raise exception on duplicated name in kubeconfig