Skip to content

Fix typos: infomration -> information #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix typos: infomration -> information #687

merged 1 commit into from
Nov 12, 2018

Conversation

charlesh001
Copy link
Contributor

Fix typos: infomration -> information

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2018
@charlesh001
Copy link
Contributor Author

/assign @lavalamp

@micw523
Copy link
Contributor

micw523 commented Nov 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2018
@micw523
Copy link
Contributor

micw523 commented Nov 11, 2018 •
edited
Loading

/lgtm cancel
I’ll leave my comments in a review instead

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2018
micw523
micw523 suggested changes Nov 11, 2018
View reviewed changes
Copy link
Contributor

@micw523 micw523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the k8s contribution guidelines ask for substantial improvements to the code base, so if you’re fixing something it’s better to fix everything at once.
Grammar nits:
detail - detailed
get number of downloads - get the number of downloads

@charlesh001
Copy link
Contributor Author

@micw523 thanks for your remind, Done the changes.

@micw523
Copy link
Contributor

micw523 commented Nov 12, 2018

/lgtm
Please squash your commits.
/cc @roycaihw

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@charlesh001
squash commits
6431af2 
Signed-off-by: maxwell <csuhp007@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@charlesh001
Copy link
Contributor Author

/lgtm
Please squash your commits.
/cc @roycaihw

squashed the commits

@micw523
Copy link
Contributor

micw523 commented Nov 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@roycaihw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huangqg, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit dca998c into kubernetes-client:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@yliaog yliaog Awaiting requested review from yliaog

@roycaihw roycaihw Awaiting requested review from roycaihw

1 more reviewer

@micw523 micw523 micw523 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lavalamp lavalamp

@micw523 micw523

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charlesh001 @micw523 @roycaihw @k8s-ci-robot @lavalamp