Skip to content

Conversation

scottilee
Copy link
Contributor

Sets up issue templates for documentation, questions, bug reports, and feature requests. This should help triaging issues and make sure that issue filers are including relevant information.

Fixes #912.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2019
@roycaihw
Copy link
Member

roycaihw commented Aug 6, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw August 6, 2019 17:38
@roycaihw
Copy link
Member

roycaihw commented Aug 7, 2019

It seems that the emeritus_approvers label doesn't prevent the bot from requesting reviews

python/OWNERS

Lines 6 to 9 in 1d51d5a

emeritus_approvers:
- caesarxuchao
- lavalamp
- mbohlool

@micw523
Copy link
Contributor

micw523 commented Aug 7, 2019

@roycaihw it did. This was sent out before that PR was approved

Copy link
Contributor

@micw523 micw523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality means the state of being functional. We should rather say “a function not currently being supported” or something like that.

Where did you pull these templates from?

@scottilee
Copy link
Contributor Author

@micw523 random places but I fixed the wording. Thanks for the catch.

@roycaihw roycaihw added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 13, 2019
@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, scottilee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9dbbc69 into kubernetes-client:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Issue Templates
4 participants