Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update cloud-provider modules to v0.22.12 #2119

Merged
merged 1 commit into from Aug 5, 2022
Merged

chore: update cloud-provider modules to v0.22.12 #2119

merged 1 commit into from Aug 5, 2022

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Aug 2, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

chore: update cloud-provider modules to v0.22.12

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

chore: update cloud-provider modules to v0.22.12, which includes upstream fixes for stale service spec issue (https://github.com/kubernetes/kubernetes/pull/107631).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2022
@coveralls
Copy link

coveralls commented Aug 2, 2022 •
edited

Coverage Status

Coverage remained the same at 80.642% when pulling a4bf42d on feiskyer:update-modules-1.1 into 023287e on kubernetes-sigs:release-1.1.

@nilo19
Copy link
Contributor

nilo19 commented Aug 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@nilo19
Copy link
Contributor

nilo19 commented Aug 3, 2022

/retest

5 similar comments
@feiskyer
Copy link
Member Author

feiskyer commented Aug 3, 2022

/retest

@nilo19
Copy link
Contributor

nilo19 commented Aug 3, 2022

/retest

@nilo19
Copy link
Contributor

nilo19 commented Aug 3, 2022

/retest

@feiskyer
Copy link
Member Author

feiskyer commented Aug 4, 2022

/retest

@MartinForReal
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

@lzhecheng
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@feiskyer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22 a4bf42d link true /test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lanlou1554
Copy link
Contributor

/retest

@feiskyer
Copy link
Member Author

feiskyer commented Aug 5, 2022

The basic lb test is flaky, would merge this PR manually

@feiskyer feiskyer merged commit 64054b0 into kubernetes-sigs:release-1.1 Aug 5, 2022
@feiskyer feiskyer deleted the update-modules-1.1 branch August 5, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@feiskyer @k8s-ci-robot @coveralls @nilo19 @MartinForReal @lzhecheng @lanlou1554