Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of network and subnetwork in GCE cloud provider #72

Closed
mkjelland opened this issue Apr 16, 2018 · 2 comments
Closed

Allow configuration of network and subnetwork in GCE cloud provider #72

mkjelland opened this issue Apr 16, 2018 · 2 comments

Comments

@mkjelland
Copy link
Contributor

mkjelland commented Apr 16, 2018 •
edited
Loading

Currently the machine actuator hard codes the network and subnetwork that it creates the instances in. Eventually we want to be able to provision networks/subnetworks for the cluster to live in. For now, we should allow users to specify the network and subnetwork names where they want the cluster to be created.

This issue includes:

  • Split GCEProviderConfig into cluster specific and machine specific configuration
  • Add networkName and subNetworkName fields to GCE cluster provider config type
  • Update instance insertion code in GCE machine actuator to create instances in network/subnetwork found in cluster.spec.cloudProvider.networkName and cluster.spec.cloudProvider.subNetworkName
  • Update cloud-config files to use specified network/subnetwork
  • Default to current behavior if network name is not passed in

Not included in this issue:

  • Generating a network/subnetwork if one does not exist with the specified name. For now, throw an error
@mkjelland
Copy link
Contributor Author

Make sure to allow for the long form of network/subnetwork (/regions/asia-northeast1/subnetworks/default) so that cross project networks will be supported.

@roberthbailey roberthbailey mentioned this issue Dec 4, 2018
Closed
@roberthbailey
Copy link
Contributor

This issue was moved to kubernetes-sigs/cluster-api-provider-gcp#69

chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#72 from kubernetes-sigs/chuckha-pa…
5ae65c2 
…tch-1

Create main.workflow
chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#72 from chuckha/verify-gofmt-fix
64d6676 
Fix verify-gofmt
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@sidharthsurana @k8s-ci-robot
Start using the new machinespec definition for creating the instance …
4e0bb12 
…on vsphere (kubernetes-sigs#72)

The code now acts accordingly based on the availability of the new cloud-init datasource
"VMwareGuestInfo" inside the template used. This availability can be set by the users in
the spec using the flag "vsphereCloudInit" set to true. For usual upstream version of
ubuntu cloud image that has been used so far, this flag need not be set at all and the
controller will utilize the OVF properties available on the ubuntu cloud image to inject
the cloud-init data.
Note: The new static IP support is only available with the templates that have the vsphere
cloud-init datasource. DHCP based IPs will continue to work as they have in the past.

Going forward we prefer users creating a custom ubuntu cloud image that also has this new
cloud-init datasource pre-installed. As that will give them the ability to use static IPs
as well if they want.

See https://github.com/akutz/cloud-init-vmware-guestinfo for more info on the new cloud-init
datasource

* Adds support for multiple nics
* Adds support for static IP

Resolves kubernetes-sigs#24
Resolves kubernetes-sigs#28

Change-Id: Id2dee12b382d57b6591f840dadd77a1c287667c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roberthbailey @mkjelland