Skip to content

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12720

/area clusterclass

…terClass

Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2025
@sbueringer
Copy link
Member

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

fabriziopandini commented Sep 30, 2025

Changes SGTM, might be just worth leaving a note on this PR about the fact that when this change will merge, the new API field, even if set, won't have any effect until other also tasks documented in #12720 will be completed in follow up PRs.

@sbueringer In the tracking issue we have a note to add corresponding validation for the new API field, but as far as I remember we decided that the runtime extension can work in combination with Kubernetes versions (with the latter used only for validation of cluster.spec.version if both are set). Is this correct?

@sbueringer
Copy link
Member

sbueringer commented Sep 30, 2025

@sbueringer In the tracking issue we have a note to add corresponding validation for the new API field, but as far as I remember we decided that the runtime extension can work in combination with Kubernetes versions (with the latter used only for validation of cluster.spec.version if both are set). Is this correct?

Yes this is correct. After our last discussion the "validation" was only referring to min length / max length etc (#12720 (comment))

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 30, 2025
@sbueringer
Copy link
Member

Thx!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f2cdcb60fabfc8cf6420b6ab99115864be42b82

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c45137 into kubernetes-sigs:main Sep 30, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants