-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Add .spec.upgrade.external.generateUpgradePlanExtension field to ClusterClass #12809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add .spec.upgrade.external.generateUpgradePlanExtension field to ClusterClass #12809
Conversation
…terClass Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
/assign @fabriziopandini |
Changes SGTM, might be just worth leaving a note on this PR about the fact that when this change will merge, the new API field, even if set, won't have any effect until other also tasks documented in #12720 will be completed in follow up PRs. @sbueringer In the tracking issue we have a note to add corresponding validation for the new API field, but as far as I remember we decided that the runtime extension can work in combination with Kubernetes versions (with the latter used only for validation of cluster.spec.version if both are set). Is this correct? |
Yes this is correct. After our last discussion the "validation" was only referring to min length / max length etc (#12720 (comment)) |
Thx! |
LGTM label has been added. Git tree hash: 7f2cdcb60fabfc8cf6420b6ab99115864be42b82
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #12720
/area clusterclass