🌱 Backport of conformance updates for Kubernetes 1.22 #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is necessary due to kubernetes/kubernetes#99178 where the conformance image now defines ENTRYPOINT (previously only CMD) which refers to conformance runner. Since this test would like to invoke ginkgo directly, overriding entrypoint is necessary to preserve existing behavior. Signed-off-by: Wilson E. Husin <wilson@husin.dev>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
randomvariable
changed the title
randomvariable
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm cancel
|
k8s-ci-robot
removed
the
lgtm
to kubetest arguments Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
remove-viper-release-03
branch
from
fa7d41d to
091b709
Compare
|
Yeah, I forgot to convert for the older go version |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport of #4761 and #4662
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #