TypeMeta is empty when using client.Get()

[kaoet]

I use client.New() to build a Client and call its Get() method to get some object. But the returned object has an empty TypeMeta.

package main

import (
	"context"
	"fmt"

	corev1 "k8s.io/api/core/v1"
	"k8s.io/client-go/kubernetes/scheme"
	_ "k8s.io/client-go/plugin/pkg/client/auth"
	"sigs.k8s.io/controller-runtime/pkg/client"
	"sigs.k8s.io/controller-runtime/pkg/client/config"
)

func main() {
	cli, err := client.New(config.GetConfigOrDie(), client.Options{Scheme: scheme.Scheme})
	if err != nil {
		panic(err)
	}
	ns := &corev1.Namespace{}
	if err := cli.Get(context.Background(), client.ObjectKey{Name: "default"}, ns); err != nil {
		panic(err)
	}
	fmt.Printf("TypeMeta: %+v\n", ns.TypeMeta)
}

Expected output:

TypeMeta: {Kind: Namespace APIVersion: v1}

Actual output:

TypeMeta: {Kind: APIVersion:}

[cndoit18]

This is an upstream error, do we need to do a temporary fix?
I can try to complete this thing.
kubernetes/kubernetes#3030
kubernetes/kubernetes#80609

[cndoit18]

@alvaroaleman
Hi, I tried to process it first in controller-runtime and then wait for the upstream to solve
What do you think?

[cndoit18]

/assign @cndoit18

[alvaroaleman]

tbh I'd prefer to not woraround this downstream and wait for someone to do it properly in upstream. The issue is IMHO not severe enough to warrant yet another downstream workaround, you can get the type info from the scheme. WDYT @vincepri ?

[cndoit18]

tbh I'd prefer to not woraround this downstream and wait for someone to do it properly in upstream. The issue is IMHO not severe enough to warrant yet another downstream workaround, you can get the type info from the scheme. WDYT @vincepri ?

I agree with this decision. thank you

[cndoit18]

You can add GVK in this way

package main

import (
	"context"
	"fmt"

	corev1 "k8s.io/api/core/v1"
	"k8s.io/client-go/kubernetes/scheme"
	_ "k8s.io/client-go/plugin/pkg/client/auth"
	"sigs.k8s.io/controller-runtime/pkg/client"
	"sigs.k8s.io/controller-runtime/pkg/client/config"
)

func main() {
	cli, err := client.New(config.GetConfigOrDie(), client.Options{Scheme: scheme.Scheme})
	if err != nil {
		panic(err)
	}
	ns := &corev1.Namespace{}
	if err := cli.Get(context.Background(), client.ObjectKey{Name: "default"}, ns); err != nil {
		panic(err)
	}

        gvks, unversioned, err := cli.Scheme().ObjectKinds(ns)
	if err != nil {
		panic(err)
	}
	if !unversioned && len(gvks) == 1 {
		ns.SetGroupVersionKind(gvks[0])
	}

	fmt.Printf("TypeMeta: %+v\n", ns.TypeMeta)
}

// output:
// TypeMeta: {Kind:Namespace APIVersion:v1}

[cndoit18]

tbh I'd prefer to not woraround this downstream and wait for someone to do it properly in upstream. The issue is IMHO not severe enough to warrant yet another downstream workaround, you can get the type info from the scheme. WDYT @vincepri ?

This issue seems to be closed, WDYT @alvaroaleman

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[alvaroaleman]

This issue seems to be closed, WDYT @alvaroaleman

Agree