Make fieldset v1 serialization alphabetical #145
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jennybuckley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -1 +1 @@ | |||
| {"f:apiVersion":{},"f:kind":{},"f:metadata":{"f:creationTimestamp":{},"f:labels":{"f:app":{},".":{}},"f:name":{},"f:namespace":{},"f:resourceVersion":{},"f:selfLink":{},"f:uid":{},".":{}},"f:subsets":{}} | |||
There was a problem hiding this comment.
Maybe we should pretty print these so that it's easier to review. The review of API changes like this are super important.
There was a problem hiding this comment.
should I add a flag to the cli to pretty print, then?
There was a problem hiding this comment.
We probably should, it can come in another PR though.
This particular change is unusual in that all prior output is still accepted, but it changes the output. We should probably include a test that the previous data remains valid.
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Move '.' to beginning of fieldset, so it serialized in the same order as default json serialization.