Bump k8s.io/client-go from 0.29.4 to 0.30.0 in /addon-resizer #6735
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
k8s-ci-robot
added
cncf-cla: yes
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -1,22 +1,23 @@ | |||
| module k8s.io/autoscaler/addon-resizer | |||
|
|
|||
| go 1.21 | |||
| toolchain go1.22.2 | |||
There was a problem hiding this comment.
I don't think this change is correct. It depends on what we build with, but right now this is being set to the go version dependabot is using.
There was a problem hiding this comment.
yeah, you are right @kwiesmueller, both should be same.
The toolchain is added now, previously it was not there.
https://github.com/kubernetes/autoscaler/blob/addon-resizer-release-1.8/addon-resizer/go.mod
It may work if we change go v1.21 to v1.21.0
https://go.dev/doc/toolchain
There was a problem hiding this comment.
As per above comment, removing lgtm from the PR
/lgtm cancel
There was a problem hiding this comment.
Hi, @kwiesmueller your thoughts on this.
k8s-ci-robot
removed
the
lgtm
dependabot
bot
force-pushed
the
dependabot/go_modules/addon-resizer/addon-resizer-release-1.8/k8s.io/client-go-0.30.0
branch
from
e34a9e0
to
c20ee45
Compare
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.29.4 to 0.30.0. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.4...v0.30.0) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/addon-resizer/addon-resizer-release-1.8/k8s.io/client-go-0.30.0
branch
from
c20ee45
to
9464709
Compare
|
Superseded by #6839. |
dependabot
bot
deleted the
dependabot/go_modules/addon-resizer/addon-resizer-release-1.8/k8s.io/client-go-0.30.0
branch
Bumps k8s.io/client-go from 0.29.4 to 0.30.0.
Commits
3aa4577Update dependencies to v0.30.0 tag2df4de1Merge remote-tracking branch 'origin/master' into release-1.30ade2ae2Update x/net for CVE-2023-45288b4632b7Merge pull request #123932 from pohly/dra-api-resource-model-rename4467b1eMerge pull request #123909 from AkihiroSuda/fix-123906650f392dra api: NodeResourceModel -> ResourceModel00e4609api: NodeStatus: rename RuntimeClasses to RuntimeHandlers7ebe0eaMerge pull request #123180 from AkihiroSuda/rro3be09aaapi: KEP-3857: Recursive Read-only (RRO) mounts110b75bMerge pull request #123344 from nilekhc/svm-controllerDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)