[stable/wordpress] Allow helm chart to receive an existing database or create it by itself Open, HighAll Users

[jbianquetti-nami]

Summary of changes:

WordPress module does not longer expect the MARIADB_USER input
WordPress module does not longer expect the MARIADB_PASSWORD input
WordPress module now expects the WORDPRESS_DATABASE_NAME input
WordPress module now expects the WORDPRESS_DATABASE_USER input
WordPress module now expects the WORDPRESS_DATABASE_PASSWORD input

Now, we can also create the database from the application side.
The ENV vars are:

MYSQL_CLIENT_CREATE_DATABASE_NAME
MYSQL_CLIENT_CREATE_DATABASE_USER
MYSQL_CLIENT_CREATE_DATABASE_PASSWORD

Also, we have added an additional security measure regarding passwordless logins.

"allowEmptyPassword": {"default": "no", "type": "choice", "validValues": ["yes", "no"], "description": "Allow to set an empty password"}

In case the container does not have the related ENV var enabled. The ENV var is:

ALLOW_EMPTY_PASSWORD

[k8s-ci-robot]

Hi @jbianquetti-nami. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jbianquetti-nami]

CLA signed.

[sameersbn]

Aside from my comments, i tested the changes and found them to be working. nice job!

[sameersbn]

we generally add the default value to the values.yaml file. I'd suggest un-commenting changing this to

allowEmptyPassword: "no"

or if you think https://github.com/kubernetes/charts/pull/773/files#r105334999 makes sense, then you should be using

allowEmptyPassword: false

[sameersbn]

if user specifies allowEmptyPassword value without qoutes, go will treat this as a boolean value. User will HAVE TO specify the allowEmptyPassword with double quotes in values.yaml, eg. allowEmptyPassword: "yes". I would not regard this as a stable UX. Instead i suggest using the following snippet.

        {{- if .Values.allowEmptyPassword }}
        - name: ALLOW_EMPTY_PASSWORD
          value: "yes"
        {{- end }}  

or

        - name: ALLOW_EMPTY_PASSWORD
        {{- if .Values.allowEmptyPassword }}
          value: "yes"
        {{- else }}
          value: "no"
        {{- end }} 

[sameersbn]

consider removing these white spaces

[sameersbn]

The mariadb chart allows you to create a database and user credentials to access the database. Rather than configuring databaseName, databaseUser and databasePassword on the wordpres chart it think mariadbDatabase, mariadbUser and mariadbPassword should be configured on the mariadb chart, similar to how mariadbRootPassword is set.

[bitnami-bot]

@jbianquetti-nami please rebase

[prydonius]

Pulling this into Milestone 4 as it blocking other WordPress updates. @jbianquetti-nami you seem to have pulled in other commits on different charts, can you please fix that?

[prydonius]

undo this change

[sameersbn]

Apart from my comment about the default value of allowEmptyPassword, the changes look good to me.

[sameersbn]

The default value is yes

[jbianquetti-nami]

Lost while rebasing. I will update it in a few minutes.

[prydonius]

Thanks @jbianquetti-nami!

[imphasing]

Would it be possible to get an example of how I would use helm to install wordpress while specifying a separate mysql host, not creating one on the cluster? I'm not seeing a way to skip installation of mariadb and specify a remote host, which I think is what this PR was intended for based on the title