Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indicate removal of PodPresets #5047

Merged
merged 1 commit into from
Oct 1, 2020
Merged

indicate removal of PodPresets #5047

merged 1 commit into from
Oct 1, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 19, 2020

indicating removal of PodPresets

xref kubernetes/kubernetes#93900
xref kubernetes/kubernetes#94090

@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

@deads2k: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. labels Aug 19, 2020
@dims
Copy link
Member

dims commented Aug 19, 2020

/approve
/lgtm

/hold please remove hold when appropriate @deads2k

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@liggitt
Copy link
Member

liggitt commented Aug 19, 2020

/lgtm

@mrbobbytables mrbobbytables removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Sep 10, 2020
@mrbobbytables
Copy link
Member

@deads2k do you think this is ready for merge?

@deads2k
Copy link
Contributor Author

deads2k commented Oct 1, 2020

/hold cancel

the change merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit dae839f into kubernetes:master Oct 1, 2020
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
@k8s-ci-robot
Merge pull request kubernetes#5047 from deads2k/remove-podpreset
4e2e494 
indicate removal of PodPresets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@mszostok mszostok Awaiting requested review from mszostok

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @k8s-ci-robot @dims @liggitt @mrbobbytables