This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: Fast drain impl that doesn't talk to api server #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Why do you need a list of daemon set?
Contributor
Author
There was a problem hiding this comment.
Removed. It remained after the original drain.
Contributor
|
LGTM, one comment. |
mwielgus
changed the title
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-drain Cluster-autoscaler: Fast drain impl that doesn't talk to api server
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-drain Cluster-autoscaler: Fast drain impl that doesn't talk to api server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @piosz @fgrzadkowski
Depends on #1009