Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

Conversation

@crigor
Copy link
Contributor

@crigor crigor commented Oct 9, 2016

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-github-robot
Copy link

[CLA-PING] @crigor

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


@k8s-github-robot k8s-github-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 9, 2016
@crigor
Copy link
Contributor Author

crigor commented Oct 9, 2016

I signed it!

@k8s-github-robot k8s-github-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2016
@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2016
@mwielgus
Copy link
Contributor

@crigor Apparently you need to sign one more CLA https://cla.developers.google.com/.

@crigor
Copy link
Contributor Author

crigor commented Oct 12, 2016

@mwielgus I've now signed that too

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8cb4035 into kubernetes-retired:master Oct 12, 2016
mwielgus pushed a commit to kubernetes/autoscaler that referenced this pull request Apr 18, 2017
Automatic merge from submit-queue

Add aws to allowed values on cluster autoscaler cloud-provider flag
mwielgus pushed a commit to kubernetes/autoscaler that referenced this pull request Apr 18, 2017
Automatic merge from submit-queue

Add aws to allowed values on cluster autoscaler cloud-provider flag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants