This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: add get nodes function to cloud provider interface #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
andrewsykim
reviewed
Jan 3, 2017
| if len(groups.AutoScalingGroups) < 1 { | ||
| return nil, fmt.Errorf("Unable to get first autoscaling.Group for %s", name) | ||
| } | ||
| return groups.AutoScalingGroups[0], nil |
There was a problem hiding this comment.
return *groups.AutoScalingGroups[0], nil? based on this
Contributor
Author
There was a problem hiding this comment.
Well, it compiles without *.
There was a problem hiding this comment.
right, cause you don't need to deference pointers to access their fields in Go. 👍
| return groups.AutoScalingGroups[0], nil | ||
| } | ||
|
|
||
| // GetMigNodes returns Asg nodes. |
Contributor
There was a problem hiding this comment.
s/GetMigNodes/GetAsgNodes/
Contributor
|
LGTM (after resolving comments) |
|
Automatic merge from submit-queue |
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…getnodes Automatic merge from submit-queue Cluster-autoscaler: add get nodes function to cloud provider interface This is needed to compare the list of nodes created by the cloud provider with the list of nodes registered in Kubernetes. Ref: #2228 #2229 cc: @jszczepkowski @andrewsykim @piosz @fgrzadkowski
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…getnodes Automatic merge from submit-queue Cluster-autoscaler: add get nodes function to cloud provider interface This is needed to compare the list of nodes created by the cloud provider with the list of nodes registered in Kubernetes. Ref: #2228 #2229 cc: @jszczepkowski @andrewsykim @piosz @fgrzadkowski
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to compare the list of nodes created by the cloud provider with the list of nodes registered in Kubernetes.
Ref: #2228 #2229
cc: @jszczepkowski @andrewsykim @piosz @fgrzadkowski