This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: introduce ClusterStateRegistry to main #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
cluster-autoscaler/scale_down.go
Outdated
|
|
||
| const ( | ||
| // MaxKubernetesNodeDeletiontime is the maximum time needed by Kubernetes to delete an empty node. | ||
| MaxKubernetesEmptyNodeDeletiontime = 3 * time.Minute |
Contributor
There was a problem hiding this comment.
Do you intend to make it configurable by flag in future?
| glog.Errorf("Problem with empty node deletion: %v", err) | ||
| finalError = err | ||
| } | ||
| case <-time.After(timeLeft): |
Contributor
There was a problem hiding this comment.
Will it behave correctly if timeLeft is negative?
Contributor
There was a problem hiding this comment.
Do you have a unittest for timeout here?
Contributor
Author
There was a problem hiding this comment.
See 10 lines above :).
Contributor
There was a problem hiding this comment.
OK ;) how abut the test?
Contributor
Author
There was a problem hiding this comment.
Not at this moment, I will be adding cloud provider failure related tests later.
mwielgus
force-pushed
the
add-registry
branch
2 times, most recently
from
542506c to
17f8af9
Compare
Contributor
|
LGTM |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @jszczepkowski @mwielgus |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @jszczepkowski @mwielgus |
|
Automatic merge from submit-queue |
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…registry Automatic merge from submit-queue Cluster-autoscaler: introduce ClusterStateRegistry to main Ref: #2228 #2229 cc: @jszczepkowski @fgrzadkowski @piosz
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…registry Automatic merge from submit-queue Cluster-autoscaler: introduce ClusterStateRegistry to main Ref: #2228 #2229 cc: @jszczepkowski @fgrzadkowski @piosz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2228 #2229
cc: @jszczepkowski @fgrzadkowski @piosz