This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: decrease node group target size if no new nodes arrive in reasonable time #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrive in reasonable time
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
| incorrectSize.CurrentSize, | ||
| delta) | ||
| if err := nodeGroup.DecreaseTargetSize(delta); err != nil { | ||
| return fixed, fmt.Errorf("Failed to decrease %s: %v", nodeGroup.Id(), err) |
Contributor
There was a problem hiding this comment.
If there is a one node group w/too large delata, the hole autoscaler algorithm for all groups will be stopped. Is it the intended behavior?
Contributor
|
LGTM |
|
Automatic merge from submit-queue |
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…decrease Automatic merge from submit-queue Cluster-autoscaler: decrease node group target size if no new nodes arrive in reasonable time cc: @jszczepkowski @andrewsykim @fgrzadkowski
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…decrease Automatic merge from submit-queue Cluster-autoscaler: decrease node group target size if no new nodes arrive in reasonable time cc: @jszczepkowski @andrewsykim @fgrzadkowski
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @jszczepkowski @andrewsykim @fgrzadkowski