This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: check node/mig state #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
force-pushed
the
check-cluster-state
branch
from
9e0fa82 to
bf06de6
Compare
cluster-autoscaler/utils.go
Outdated
Contributor
There was a problem hiding this comment.
nit: you don't need the second variable here
Contributor
|
LGTM, just a nit |
Contributor
|
👊 👊 👊 |
mwielgus
force-pushed
the
check-cluster-state
branch
from
bf06de6 to
03fb8f2
Compare
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-cluster-state Cluster-autoscaler: check node/mig state
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-cluster-state Cluster-autoscaler: check node/mig state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @piosz @fgrzadkowski