This repository was archived by the owner on Apr 17, 2019. It is now read-only.
[cluster-autoscaler] Add support for PodScheduled condition. #978
+83
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI I haven't tested this manually e2e. |
cluster-autoscaler/utils.go
Outdated
Contributor
There was a problem hiding this comment.
typo: should be UnschedulablePodLister
fgrzadkowski
force-pushed
the
use_pod_condition
branch
from
521dc09 to
08af17c
Compare
Contributor
Author
|
All comments addressed. PTAL. |
fgrzadkowski
force-pushed
the
use_pod_condition
branch
from
08af17c to
93c386d
Compare
Contributor
|
lgtm |
fgrzadkowski
force-pushed
the
use_pod_condition
branch
from
93c386d to
e000a21
Compare
fgrzadkowski
force-pushed
the
use_pod_condition
branch
from
e000a21 to
7a21250
Compare
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…se_pod_condition [cluster-autoscaler] Add support for PodScheduled condition.
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…se_pod_condition [cluster-autoscaler] Add support for PodScheduled condition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic is the following:
PodScheduledcondition toUnknownfor all the pods with statusTrueand reasonUnschedulablewithLastTransitionTimebefore timestamp from 1)Ref: #25553