This repository was archived by the owner on Apr 17, 2019. It is now read-only.
cluster-autoscaler: Fix slicing pods into old pods and new pods #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Do you need to introduce this new variable?
Contributor
|
LGTM, just a nit |
fgrzadkowski
force-pushed
the
deployment_scripts
branch
from
21d1a8a to
74f3a1c
Compare
…(to assume as unschedulable).
fgrzadkowski
force-pushed
the
deployment_scripts
branch
from
74f3a1c to
6d4d9aa
Compare
Contributor
Author
|
Apart from addressing your comments I'm adding a separate commit that fixes our makefile. |
Contributor
|
LGTM |
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…eployment_scripts cluster-autoscaler: Fix slicing pods into old pods and new pods
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…eployment_scripts cluster-autoscaler: Fix slicing pods into old pods and new pods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously after updating pod status all pods had
LastTransitionTimeafter the threshold (time of newest node becoming available).Additionally fix our makefile so that it's not required to set
REGISTRYfor every rule.kubernetes/kubernetes#24404
@mwielgus @jszczepkowski @piosz