PDB support for custom resources with scale subresource

[mortent]

PDB support for custom resources with scale subresource

• One-line enhancement description (can be used as a release note): PDB support for custom resources with scale subresource
• Kubernetes Enhancement Proposal PR: Add a KEP for PDB support for custom resources with scale subresource #963
• Kubernetes Enhancement Proposal: 20190412-pdb-support-for-custom-resources-with-scale-subresource
• Primary contact (assignee): @mortent
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Beta release target (1.15): This will be an enhancement to the current PDB beta.
  • Stable release target (1.16): Goal is to promote PDBs to GA in 1.16. KEP: Add a KEP for graduating PodDisruptionBudget to stable #904

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[mortent]

/sig apps

[mrbobbytables]

/milestone v1.15
/stage beta

[justaugustus]

/assign @mortent

[christianh814]

Hey @mortent I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[mortent]

PR has merged: kubernetes/kubernetes#76294
Docs PR: kubernetes/website#14519

[craiglpeters]

Hi @mortent . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open. It appears that kubernetes/kubernetes#76294 has merged and you have a docs PR, so you're in good shape. Are there any other PRs associated with this KEP?

Thanks!

[mortent]

@craiglpeters This PR and the docs PR should be everything. So should be all done once the docs PR merge.

[craiglpeters]

@mortent great - looking good

[kacole2]

Hi @mortent, I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[mortent]

@kacole2 We plan on taking PodDisruptionBudgets to GA in 1.16. KEP is #904

[kacole2]

/milestone v1.16
/stage stable

[kacole2]

@mortent this is a reminder that tomorrow is Enhancement Freeze. Can you let me know how this is connected to #85 and if this issue is requiring #904 to be merged?

[mortent]

@kacole2 I created this issue for 1.15 for the change to expand PDB support to custom resources. For 1.16 we are planning to bring the full PDB api to GA. Should we keep this issue for this?
I will follow up to get a last lgtm to #904 so it can be merged.

[kacole2]

@mortent for tracking purposes, does this issue of "PDB support for custom resources with scale subresource" encompass or umbrella "the full PDB api to GA"? If so, then it needs to be tracked.

If #85 is "the full PDB api to GA", then we need to track #85.

[mortent]

@kacole2 I consider them two separate efforts, so I think it would make sense to close this and either create a new issue to track the GA effort or we can track it through #85.

It looks like #85 has not been updated in a while as PDBs has been in beta for several releases. The effort has been guided by the discussion in #904

[kacole2]

@mortent thanks for the clarification.

I would like to have a single issue be tracking a KEP as it graduates between stages. No need to create a new issue every time.

If there is an additional enhancement created that is not "core" to the original enhancement, we can create a new feature.

So #904 is exactly what we need as it relates to #85 . A single KEP should be associated with a single issue. The KEP graduation criteria matches the labels associated with the issue so it's easier to track.

If there are two separate efforts that correlate to two difference enhancements (or an added enhancement on existing feature) then we should have two issues with two KEPs.

Let me know if that makes sense and what you recommend for keeping this issue closed and tracking in #85 or continuing to track separately.

[mortent]

@kacole2 That makes sense. Let's close this one as it tracked a relatively minor improvement to PDBs and this change shipped with 1.15. Then we use #85 to track the GA work. I will update #85 to reflect the current state of PDBs.

[kacole2]

/milestone clear
/close

[k8s-ci-robot]

@kacole2: Closing this issue.

In response to this:

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.