Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDB support for custom resources with scale subresource #981

Closed
mortent opened this issue Apr 22, 2019 · 19 comments
Closed

PDB support for custom resources with scale subresource #981

mortent opened this issue Apr 22, 2019 · 19 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@mortent
Copy link
Member

mortent commented Apr 22, 2019

PDB support for custom resources with scale subresource

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 22, 2019
@mortent
Copy link
Member Author

mortent commented Apr 22, 2019

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 22, 2019
@kacole2 kacole2 added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Apr 23, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 24, 2019

/milestone v1.15
/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 24, 2019
@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 24, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @mortent

@christianh814
Copy link

christianh814 commented May 13, 2019

Hey @mortent I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@mortent
Copy link
Member Author

mortent commented May 24, 2019

PR has merged: kubernetes/kubernetes#76294
Docs PR: kubernetes/website#14519

@craiglpeters
Copy link
Contributor

craiglpeters commented May 29, 2019

Hi @mortent . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open. It appears that kubernetes/kubernetes#76294 has merged and you have a docs PR, so you're in good shape. Are there any other PRs associated with this KEP?

Thanks!

@mortent
Copy link
Member Author

mortent commented May 30, 2019

@craiglpeters This PR and the docs PR should be everything. So should be all done once the docs PR merge.

@craiglpeters
Copy link
Contributor

craiglpeters commented May 30, 2019

@mortent great - looking good

@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019

Hi @mortent, I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 9, 2019
@kacole2 kacole2 removed this from the v1.15 milestone Jul 9, 2019
@mortent
Copy link
Member Author

mortent commented Jul 9, 2019

@kacole2 We plan on taking PodDisruptionBudgets to GA in 1.16. KEP is #904

@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

/milestone v1.16
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 9, 2019
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jul 9, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 29, 2019

@mortent this is a reminder that tomorrow is Enhancement Freeze. Can you let me know how this is connected to #85 and if this issue is requiring #904 to be merged?

@mortent
Copy link
Member Author

mortent commented Jul 30, 2019

@kacole2 I created this issue for 1.15 for the change to expand PDB support to custom resources. For 1.16 we are planning to bring the full PDB api to GA. Should we keep this issue for this?
I will follow up to get a last lgtm to #904 so it can be merged.

@kacole2
Copy link
Member

kacole2 commented Jul 30, 2019

@mortent for tracking purposes, does this issue of "PDB support for custom resources with scale subresource" encompass or umbrella "the full PDB api to GA"? If so, then it needs to be tracked.

If #85 is "the full PDB api to GA", then we need to track #85.

@mortent
Copy link
Member Author

mortent commented Jul 30, 2019

@kacole2 I consider them two separate efforts, so I think it would make sense to close this and either create a new issue to track the GA effort or we can track it through #85.

It looks like #85 has not been updated in a while as PDBs has been in beta for several releases. The effort has been guided by the discussion in #904

@kacole2
Copy link
Member

kacole2 commented Jul 30, 2019

@mortent thanks for the clarification.

I would like to have a single issue be tracking a KEP as it graduates between stages. No need to create a new issue every time.

If there is an additional enhancement created that is not "core" to the original enhancement, we can create a new feature.

So #904 is exactly what we need as it relates to #85 . A single KEP should be associated with a single issue. The KEP graduation criteria matches the labels associated with the issue so it's easier to track.

If there are two separate efforts that correlate to two difference enhancements (or an added enhancement on existing feature) then we should have two issues with two KEPs.

Let me know if that makes sense and what you recommend for keeping this issue closed and tracking in #85 or continuing to track separately.

@mortent
Copy link
Member Author

mortent commented Jul 30, 2019

@kacole2 That makes sense. Let's close this one as it tracked a relatively minor improvement to PDBs and this change shipped with 1.15. Then we use #85 to track the GA work. I will update #85 to reflect the current state of PDBs.

@kacole2
Copy link
Member

kacole2 commented Jul 30, 2019

/milestone clear
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2019

@kacole2: Closing this issue.

In response to this:

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Jul 30, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

7 participants