-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Description
The nginx-https
example (currently _archived
) refers to two different nginxhttps
images:
image: ymqytw/nginxhttps:1.5 |
examples/_archived/https-nginx/Makefile
Line 18 in 0598f07
PREFIX = bprashanth/nginxhttps |
Would it be possible to base this example on the official nginx image instead?
The additional bit of nginx configuration required for https would help to clarify what's going on.
Note, actually, the Dockerfile
already is based on the official nginx
image:
examples/_archived/https-nginx/Dockerfile
Line 15 in 0598f07
FROM nginx |
and I assume this is supposed to be built using make container
:
examples/_archived/https-nginx/Makefile
Lines 27 to 29 in 0598f07
container: | |
docker build --pull -t $(PREFIX):$(TAG) . | |
but none of this is clear from the readme.
This example is essential for people following the tutorial on https://kubernetes.io/docs/tutorials/services/connect-applications-service/#exposing-the-service