-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Deploy vLLM example to separate namespace #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seans3
commented
Sep 10, 2025
- Updates example to deploy vLLM example to separate namespace (instead of default namespace).
/assign @janetkuo |
AI/vllm-deployment/vllm-service.yaml
Outdated
kind: Service | ||
metadata: | ||
name: vllm-service | ||
namespace: vllm-example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest omitting the namespace from resource manifests and specify it at deploy time. This makes the manifest more reusable so that users can apply this manifest directly without modifying it for their own namespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9b9df13
to
45c5bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
kubectl create namespace vllm-example | ||
``` | ||
|
||
2. Ensure Hugging Face permissions to retrieve model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - you can just use 1.
and markdown will render a ordered list for you, so that you don't need to update the number whenever you add/remove something from the list.
e.g.
1. xxx
1. xxx
is rendered as
- xxx
- xxx
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janetkuo, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |