Skip to content

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Sep 10, 2025

  • Updates example to deploy vLLM example to separate namespace (instead of default namespace).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2025
@seans3
Copy link
Contributor Author

seans3 commented Sep 10, 2025

/assign @janetkuo

kind: Service
metadata:
name: vllm-service
namespace: vllm-example
Copy link
Member

@janetkuo janetkuo Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest omitting the namespace from resource manifests and specify it at deploy time. This makes the manifest more reusable so that users can apply this manifest directly without modifying it for their own namespaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kubectl create namespace vllm-example
```

2. Ensure Hugging Face permissions to retrieve model:
Copy link
Member

@janetkuo janetkuo Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - you can just use 1. and markdown will render a ordered list for you, so that you don't need to update the number whenever you add/remove something from the list.

e.g.

1. xxx 
1. xxx

is rendered as

  1. xxx
  2. xxx

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit fbb2da7 into kubernetes:master Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants