Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSC Rename #2596

Closed
wants to merge 2 commits into from
Closed

PSC Rename #2596

wants to merge 2 commits into from

Conversation

lukehinds
Copy link
Contributor

This is pull request is part of the process to rename the product
security commitee to the security response commmitee.

Please see the community
issue

Signed-off-by: Luke Hinds lhinds@redhat.com

PSC Rename
f38935d 
This is pull request is part of the process to rename the product
security commitee to the security response commmitee.

Please see [the community
issue](https://github.com/kubernetes/community/pull/5597/files)

Signed-off-by: Luke Hinds <lhinds@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/groups Google Groups management, code in groups/ committee/security-response Denotes an issue or PR intended to be handled by the product security committee. wg/k8s-infra labels Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lukehinds
To complete the pull request process, please assign cblecker after the PR has been reviewed.
You can assign the PR to them by writing /assign @cblecker in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Missed entries during PSC rename
1860682 
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

@lukehinds: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-k8sio-groups-test 1860682 link /test pull-k8sio-groups-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

spiffxp
spiffxp suggested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because restrictions points to a renamed file path, but it doesn't exist

groups/restrictions.yaml
- path: "committee-product-security/groups.yaml"
- path: "committee-security-response/groups.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move the files to this new directory

spiffxp added a commit to spiffxp/k8s.io that referenced this pull request Sep 16, 2021
@spiffxp
groups: rename PSC to committee-security-response
f6695ad 
Related:
- Part of: kubernetes/community#5597
- Supercedes: kubernetes#2596
@spiffxp spiffxp mentioned this pull request Sep 16, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Sep 16, 2021

/close
Closing in favor of #2745

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
Closing in favor of #2745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp requested changes

@micahhausler micahhausler Awaiting requested review from micahhausler

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@spiffxp spiffxp

Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukehinds @k8s-ci-robot @spiffxp