Skip to content

Remove GA featuregate about ProxyTerminatingEndpoints in 1.30 #122134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 14, 2023
Merged

Remove GA featuregate about ProxyTerminatingEndpoints in 1.30 #122134

k8s-ci-robot merged 1 commit into from
Dec 14, 2023

Conversation

@taoyounger
Copy link
Contributor

@taoyounger taoyounger commented Dec 1, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature gate `ProxyTerminatingEndpoints`.

@taoyounger
Remove GA featuregate about ProxyTerminatingEndpoints in 1.30
e13dca6 
Signed-off-by: tao.yang <tao.yang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2023

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Dec 1 04:07:07 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2023

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t December 1, 2023 06:57
@wojtek-t
Copy link
Member

wojtek-t commented Dec 1, 2023

/sig network
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 1, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2023

LGTM label has been added.

Git tree hash: d69cdf3787f1801438b0fbb79f8bdaef9c9c778f

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ty-dc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9694ebd into kubernetes:master Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 14, 2023
@sftim
Copy link
Contributor

sftim commented Dec 19, 2023

Changelog suggestion

Removed generally available feature gate `ProxyTerminatingEndpoints`.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 20, 2023
brb added a commit to cilium/cilium that referenced this pull request Jan 30, 2025
@brb
agent: Deprecate --enable-k8s-terminating-endpoint flag
208aea0 
The ProxyTerminatingEndpoint feature was made GA since K8s v1.28, and
thus we can enable it unconditionally [1].

kubernetes/kubernetes#122134

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb mentioned this pull request Jan 30, 2025
Merged
brb added a commit to cilium/cilium that referenced this pull request Jan 30, 2025
@brb
agent: Deprecate --enable-k8s-terminating-endpoint flag
8e6a2a6 
The ProxyTerminatingEndpoint feature was made GA since K8s v1.28, and
thus we can enable it unconditionally [1].

kubernetes/kubernetes#122134

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this pull request Jan 30, 2025
@brb
agent: Deprecate --enable-k8s-terminating-endpoint flag
1d48fa8 
The ProxyTerminatingEndpoint feature was made GA since K8s v1.28, and
thus we can enable it unconditionally [1].

kubernetes/kubernetes#122134

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

4 participants

@taoyounger @k8s-ci-robot @wojtek-t @sftim