-
Notifications
You must be signed in to change notification settings - Fork 41.9k
Automated cherry pick of #128307: bugfix(scheduler): preemption picks wrong victim node with higher priority pod on it #128434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dfc7158 to
f8967da
Compare
…ority pod on it. Introducing pdb to preemption had disrupted the orderliness of pods in the victims,
f8967da to
df37614
Compare
kerthcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 2600c6bd894771bfeac44a5ff5232c1ab5ba9c06
|
|
/kind bug |
|
/remove-sig api-machinery |
|
/remove-sig auth |
|
/triage accepted |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet, NoicFank, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@NoicFank: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Cherry pick of #128307 on release-1.30.
#128307: bugfix(scheduler): preemption picks wrong victim node with higher priority pod on it
For details on the cherry pick process, see the cherry pick requests page.