Skip to content

Conversation

yastij
Copy link
Member

@yastij yastij commented Sep 25, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup
/priority important-soon

What this PR does / why we need it: This bumps k8s.io/utils to pickup ipallocator changes, they will be used on follow-up PR to prune some of the kubeadm dependencies to k/k

Which issue(s) this PR fixes: part of kubernetes/kubeadm#1600

Special notes for your reviewer:

/assign @liggitt @dims

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 25, 2019
@liggitt
Copy link
Member

liggitt commented Sep 25, 2019

fyi @vegemitecheesetoast

@k8s-ci-robot k8s-ci-robot requested review from a team, andrewsykim and andyzhangx September 25, 2019 14:37
@liggitt
Copy link
Member

liggitt commented Sep 25, 2019

this lgtm, but is still marked WIP. is there work remaining?

@yastij yastij changed the title [WIP] bump k8s.io/utils to pickup ipallocator changes bump k8s.io/utils to pickup ipallocator changes Sep 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2019
@yastij
Copy link
Member Author

yastij commented Sep 25, 2019

@liggitt - typo, this should be ready to go

@liggitt
Copy link
Member

liggitt commented Sep 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@yastij
Copy link
Member Author

yastij commented Sep 25, 2019

/retest

2 similar comments
@yastij
Copy link
Member Author

yastij commented Sep 25, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Sep 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 28bcf55 into kubernetes:master Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 25, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
bump k8s.io/utils to pickup ipallocator changes

Kubernetes-commit: 28bcf55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants