Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relnotes can't determine a last release on a new branch #70

Closed
david-mcmahon opened this issue Sep 10, 2016 · 1 comment
Closed

relnotes can't determine a last release on a new branch #70

david-mcmahon opened this issue Sep 10, 2016 · 1 comment
Assignees
@david-mcmahon
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@david-mcmahon
Copy link
Contributor

It has to do with the github::last_releases() and how github's release page is our canonical source for releases. We currently treat a branch event as a non-release event, so github's release page won't show a new branch beta tag as a release. We either need to treat beta.0's as releases (probably best) or workaround the fact beta.0 is not a release.

cc @pwittrock @ixdy
@david-mcmahon david-mcmahon self-assigned this Sep 10, 2016
@david-mcmahon david-mcmahon mentioned this issue Sep 10, 2016
Merged
@pwittrock
Copy link
Member

Betas as releases makes sense to me since we are doing that for alphas.

marpaia pushed a commit to marpaia/release that referenced this issue Feb 21, 2019
@k8s-ci-robot
Merge pull request kubernetes#70 from calebamiles/wip-propose-calebam…
042a1a5 
…iles-branch-manger

propose caleb miles as 1.10 branch manager
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-mcmahon david-mcmahon

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justaugustus @pwittrock @david-mcmahon