Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Snap packaging support. #293
This PR adds support for snap packages, fixing #44, for the following kubernetes components:
These follow the same process for deb and RPM by including the appropriate component from the k8s.io build.
Thank you for this patch! Adding snap packages to Kubernetes is just great!
I'll take deeper look into this after KubeCon, but I think we should only build packages for kubelet, kubeadm and kubectl. Also we need a package for the CNI binaries.
There should also be snap packages for all available architectures (see the deb process for more info how to easily do that).
Took a super-quick pass and I'm asking myself why there are snaps for apiserver/controller-manager/scheduler/kube-proxy
I don't think those should be debs, the preferred way to run those is in containers.
Re multiarch: You can just download all binaries for all arches from the CI builds -- please look at the deb creation for the specific URLs to use.
No need to compile anything by hand
As this is a known issue moving forward, that we only have AMD64 bins in the snap channels today we have additional incoming feedback requesting PPC64EL. Linking these two issues together so we can continue to track as the status evolves
@luxas it appears to be an upstream bug; snapcraft will not build packages for anything other than the current architecture, even if the architecture is listed in the snapcraft.yaml.
Unfortunately, I don't think there's much to be done for multiarch support until upstream fixes this.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: wwwtyro
If they are not already assigned, you can assign the PR to them by writing
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.