Skip to content

fix duplicate short hand, remove duplicated flags and mark deprecated the create-website-pr #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
+3 −15
Merged

fix duplicate short hand, remove duplicated flags and mark deprecated the create-website-pr #4123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/krel/cmd/release_notes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,13 @@ func init() {
releaseNotesCmd.PersistentFlags().StringSliceVarP(
&releaseNotesOpts.includeLabels,
"include-labels",
"l",
"",
[]string{},
"only PRs with one of these labels are considered. Set to empty to include all PRs",
)

_ = releaseNotesCmd.PersistentFlags().MarkDeprecated("create-website-pr", "This flag is deprecated and will be removed in a future release. Use --create-draft-pr instead.")

rootCmd.AddCommand(releaseNotesCmd)
}

Expand Down
14 changes: 0 additions & 14 deletions cmd/release-notes/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,6 @@ func addGenerateFlags(subcommand *cobra.Command) {
[]string{},
"specify a location to recursively look for release notes *.y[a]ml file mappings",
)
subcommand.PersistentFlags().BoolVar(
&opts.ListReleaseNotesV2,
"list-v2",
false,
"enable experimental implementation to list commits (ListReleaseNotesV2)",
)

subcommand.PersistentFlags().StringSliceVarP(
&opts.IncludeLabels,
"include-labels",
"l",
[]string{},
"Only PRs with one of these labels are considered. Set to empty to include all PRs",
)
}

// addGenerate adds the generate subcomand to the main release notes cobra cmd.
Expand Down